[release/2.11] Skip known-failing ROCm 7.14 and MemPool tests; fix test_typing name_fn - #3599
Open
dnikolaev-amd wants to merge 3 commits into
Open
[release/2.11] Skip known-failing ROCm 7.14 and MemPool tests; fix test_typing name_fn#3599dnikolaev-amd wants to merge 3 commits into
dnikolaev-amd wants to merge 3 commits into
Conversation
…orch#185013) Skip test_mempool_no_split and test_nested_mempool on Linux while MemPool segment counting is incompatible with expandable_segments. (cherry picked from commit 9661ae6)
…torch#192648) Generated test names ending in ".py" break unittest name-based loading (too many values to unpack). Use splitext in name_fn so subtests are addressable by name. Use a single mypy==1.16.0 pin in requirements-ci.txt so check_mypy_version.py can resolve the CI mypy version. (cherry picked from commit 51154e2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick targeted CI stabilizations onto
release/2.11for TheRock / ROCm 7.14 testing. Test skips and test-infra helpers only.test_mempool_no_splitandtest_nested_mempoolon Linux while MemPool segment counting is incompatible withexpandable_segments(#180325, #180367).lazy_skip_if,skipIfRocmVersionAtLeast, andskip_if_rocm_ver_atleast_multiprocess; skip known-failing export, serialization, utils, and distributed tests on ROCm ≥ 7.14.name_fnto strip.pyfrom subtest names (fixestoo many values to unpackwhen running individual tests). Collapserequirements-ci.txtto a singlemypy==1.16.0pin socheck_mypy_version.pyworks.Test plan
python test/test_cuda.py TestMemPool.test_mempool_no_split TestMemPool.test_nested_mempool— skipped on LinuxPYTORCH_TEST_WITH_ROCM=1 python test/test_serialization.py TestSerialization.test_debug_set_in_ci— skipped on ROCm 7.14+PYTORCH_TEST_WITH_ROCM=1 python test/test_utils.py TestStandaloneCPPJIT.test_load_standalone— skipped on ROCm 7.14+PYTORCH_TEST_WITH_ROCM=1 python test/export/test_export_opinfo.py TestExportOnFakeCudaCUDA— skipped (9 tests)PYTORCH_TEST_WITH_ROCM=1 python test/distributed/test_ce_colls.py NCCLCopyEngineCollectives.test_ce_allgather NCCLCopyEngineCollectives.test_ce_alltoall— skippedPYTORCH_TEST_WITH_ROCM=1 python test/distributed/test_symmetric_memory.py SymmetricMemoryTest.test_subgroup SymmMemCollectiveTest.test_one_shot_all_reduce SymmMemCollectiveTest.test_two_shot_all_reduce— skippedpython test/test_typing.py TestTyping— 18/18 pass