Add quick-tune support for Attention #2169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirza-halilcevic
requested review from
dhernandez0,
dorde-antic and
umangyadav
dhernandez0
reviewed
Dec 11, 2025
mlir/include/mlir/Dialect/Rock/Tuning/QuickTuningPerfconfigs.inc
Outdated
Show resolved
Hide resolved
dhernandez0
reviewed
Dec 12, 2025
Contributor
There was a problem hiding this comment.
nit: own file for attention/g+g?
dhernandez0
approved these changes
Dec 12, 2025
dhernandez0
reviewed
Dec 15, 2025
|
|
||
| #ifdef Attn_LOOKUP_TABLE_GEN | ||
|
|
||
| {"gfx900_attention_f32", {PopulateParamsAttn::initParametersAttentionGfx900, PopulateParamsAttn::nInitParametersAttentionGfx900}}, |
Contributor
There was a problem hiding this comment.
I guess temporarily, gemm+gemm kernels will use attention quick tuning list but eventually, we'll have a list for gemm_gemm? (and potentially conv+gemm). We already have a tier1-gemmgemm list
Contributor
Author
There was a problem hiding this comment.
Yes, the ticket is in progress https://github.com/ROCm/rocMLIR-internal/issues/2019
- Retire InitParamsNonAccel and InitParamsAccel - Combine MfmaGemmParamsAttr and WmmaGemmParamsAttr into AccelGemmParamsAttr
dhernandez0
reviewed
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement proper quick tuning support for Attention operations.
Technical Details
Resolves https://github.com/ROCm/rocMLIR-internal/issues/1887
Resolves https://github.com/ROCm/rocMLIR-internal/issues/1447
Test Plan
Test Result
Submission Checklist