Skip to content

Conversation

@cgmb
Copy link
Collaborator

@cgmb cgmb commented Mar 12, 2025

The gfx11-generic build target would reduce build times and binary size by replacing four ISAs with one.

The gfx11-generic build target would reduce build times and binary size
by replacing four ISAs with one.
@cgmb
Copy link
Collaborator Author

cgmb commented Mar 14, 2025

There is a bug in rocm_check_target_ids, so making the target optional would require ROCm/rocm-cmake#265.

@cgmb
Copy link
Collaborator Author

cgmb commented Mar 14, 2025

The gfx11-generic target requires -mcode-object-version=6 for amdclang++ older than ROCm 6.4. Using COV6 with versions of clang from before this December commit will result in a warning that "code object v6 is still in development and not ready for production use yet."

@cgmb cgmb changed the title Use gfx11-generic target Use gfx11-generic and gfx12-generic targets Apr 28, 2025
@cgmb cgmb marked this pull request as ready for review April 28, 2025 23:12
@cgmb
Copy link
Collaborator Author

cgmb commented Apr 29, 2025

The User Guide for AMDGPU Backend has some excellent information about the generic targets. For gfx12-generic, there should be no drawbacks. For gfx11-generic, there are some instruction restrictions that may or may not affect performance.

I'm happy to see the tests passing, but I think I will split this into two PRs because the gfx12-generic update is a no-brainer and the gfx11-generic update may require a bit of consideration.

@cgmb cgmb force-pushed the use-gfx11-generic branch from 67765c1 to d20b083 Compare April 29, 2025 19:10
@cgmb cgmb changed the title Use gfx11-generic and gfx12-generic targets Use gfx11-generic targets Apr 29, 2025
@TorreZuk TorreZuk added the gfxall PR to develop build all default gfx label May 5, 2025
@ammallya
Copy link
Contributor

Imported to ROCm/rocm-libraries

@ammallya ammallya closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gfxall PR to develop build all default gfx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants