Skip to content

fix(dash): wire client-side log file and instrument chat lifecycle #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelroy-amd wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(dash): wire client-side log file and instrument chat lifecycle #103

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2331cfd
fix(dash): wire client-side tracing subscriber + chat lifecycle logging
michaelroy-amd Jul 11, 2026
1bb216d
fix(dash): remove global-subscriber race assertion in logging test
michaelroy-amd Jul 11, 2026
fd513dc
fix(dash): bound client logs at MAX_RETAINED_LOGS and stop tests litt…
michaelroy-amd Jul 11, 2026
635b986
fix(dash): regenerate manifest/TPN and harden log path against traversal
michaelroy-amd Jul 11, 2026
30bda63
build(tpn): pin ureq's license to MIT so THIRD_PARTY_NOTICES is repro…
michaelroy-amd Jul 11, 2026
dc0d985
build(tpn): clarify ureq to Apache-2.0 and regenerate deterministic n…
michaelroy-amd Jul 11, 2026
3a78b42
test(dash): drop tainted temp-dir fallback so CodeQL taint is fully cut
michaelroy-amd Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions MANIFEST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ repository.
| cpufeatures | 0.2.17 | MIT OR Apache-2.0 |
| crc32fast | 1.5.0 | MIT OR Apache-2.0 |
| critical-section | 1.2.0 | MIT OR Apache-2.0 |
| crossbeam-channel | 0.5.16 | MIT OR Apache-2.0 |
| crossbeam-utils | 0.8.21 | MIT OR Apache-2.0 |
| crossterm | 0.28.1 | MIT |
| crossterm | 0.29.0 | MIT |
Expand Down Expand Up @@ -411,6 +412,7 @@ repository.
| strum_macros | 0.26.4 | MIT |
| strum_macros | 0.28.0 | MIT |
| subtle | 2.6.1 | BSD-3-Clause |
| symlink | 0.1.0 | MIT/Apache-2.0 |
| syn | 1.0.109 | MIT OR Apache-2.0 |
| syn | 2.0.118 | MIT OR Apache-2.0 |
| sync_wrapper | 1.0.2 | Apache-2.0 |
Expand Down Expand Up @@ -452,6 +454,7 @@ repository.
| tower-layer | 0.3.3 | MIT |
| tower-service | 0.3.3 | MIT |
| tracing | 0.1.44 | MIT |
| tracing-appender | 0.2.5 | MIT |
| tracing-attributes | 0.1.31 | MIT |
| tracing-core | 0.1.36 | MIT |
| tracing-error | 0.2.1 | MIT |
Expand Down
5 changes: 4 additions & 1 deletion THIRD_PARTY_NOTICES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1725,7 +1725,6 @@ Apache License 2.0

The following component(s) are licensed under Apache License 2.0:
- rustls-platform-verifier 0.7.0 <https://github.com/rustls/rustls-platform-verifier>
- ureq 2.12.1 <https://github.com/algesten/ureq>

Apache License
Version 2.0, January 2004
Expand Down Expand Up @@ -5552,6 +5551,7 @@ The following component(s) are licensed under Apache License 2.0:
- core-foundation 0.10.1 <https://github.com/servo/core-foundation-rs>
- core-foundation 0.9.4 <https://github.com/servo/core-foundation-rs>
- critical-section 1.2.0 <https://github.com/rust-embedded/critical-section>
- crossbeam-channel 0.5.16 <https://github.com/crossbeam-rs/crossbeam>
- crossbeam-utils 0.8.21 <https://github.com/crossbeam-rs/crossbeam>
- displaydoc 0.2.6 <https://github.com/yaahc/displaydoc>
- either 1.16.0 <https://github.com/rayon-rs/either>
Expand Down Expand Up @@ -5631,6 +5631,7 @@ The following component(s) are licensed under Apache License 2.0:
- smallvec 1.15.2 <https://github.com/servo/rust-smallvec>
- socket2 0.6.4 <https://github.com/rust-lang/socket2>
- stable_deref_trait 1.2.1 <https://github.com/storyyeller/stable_deref_trait>
- symlink 0.1.0 <https://gitlab.com/chris-morgan/symlink>
- system-configuration-sys 0.6.0 <https://github.com/mullvad/system-configuration-rs>
- system-configuration 0.7.0 <https://github.com/mullvad/system-configuration-rs>
- tar 0.4.46 <https://github.com/composefs/tar-rs>
Expand All @@ -5642,6 +5643,7 @@ The following component(s) are licensed under Apache License 2.0:
- unicode-truncate 2.0.1 <https://github.com/Aetf/unicode-truncate>
- unicode-width 0.1.14 <https://github.com/unicode-rs/unicode-width>
- unicode-width 0.2.0 <https://github.com/unicode-rs/unicode-width>
- ureq 2.12.1 <https://github.com/algesten/ureq>
- url 2.5.8 <https://github.com/servo/rust-url>
- uuid 1.23.3 <https://github.com/uuid-rs/uuid>
- wasi 0.11.1+wasi-snapshot-preview1 <https://github.com/bytecodealliance/wasi>
Expand Down Expand Up @@ -8885,6 +8887,7 @@ MIT License
================================================================================

The following component(s) are licensed under MIT License:
- tracing-appender 0.2.5 <https://github.com/tokio-rs/tracing>
- tracing-attributes 0.1.31 <https://github.com/tokio-rs/tracing>
- tracing-core 0.1.36 <https://github.com/tokio-rs/tracing>
- tracing-error 0.2.1 <https://github.com/tokio-rs/tracing>
Expand Down
3 changes: 3 additions & 0 deletions apps/rocm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ rpassword.workspace = true
serde.workspace = true
serde_json.workspace = true
tar = "0.4"
tracing = "0.1"
tracing-appender = "0.2"
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
ureq = { version = "2.12", features = ["native-certs"] }

[target.'cfg(target_os = "windows")'.dependencies]
Expand Down
Loading
Loading