feat(dash): make the ROCm/Serving detail pane state-aware#93
Open
michaelroy-amd wants to merge 2 commits into
Open
feat(dash): make the ROCm/Serving detail pane state-aware#93michaelroy-amd wants to merge 2 commits into
michaelroy-amd wants to merge 2 commits into
Conversation
The Actions -> Details pane rendered fixed copy. Thread `&AppState` into `pane::draw`/`draw_detail` and render a live status block per verb: - Set up / Install ROCm: detected ROCm + driver versions and installed runtimes - Serve a model: the known-model catalog - Engines: Lemonade install status (vLLM deferred until the daemon surfaces it) - Running instances: live instances inline (model/port/gen tps) — no popup Falls back to honest "not detected" / "none running" when telemetry is absent. Adds tab tests for the populated install + running-instances paths. Signed-off-by: Michael Roy <michael.roy@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Actions → Details pane on the ROCm and Serving tabs rendered fixed copy regardless of system state. Thread
&AppStateintopane::draw/draw_detailand render a live status block per verb:Falls back to honest
not detected/none runningwhen telemetry is absent, so it degrades correctly on machines without ROCm.Tests
--test-threads=1), clippy-D warningsclean.Notes
Part 3 of 3 for today's dash UX work. Independent of #91 / #92 (disjoint files) — mergeable in any order.
Follow-on (not in this PR): real downloaded-model detection and vLLM install detection need a new background fetch +
AppStatefields.