Fix clang tidy error with long path names

Author: pfultz2

share/rocmcmakebuildtools/cmake/ROCMClangTidy.cmake

@@ -192,24 +192,26 @@ function(rocm_clang_tidy_check TARGET)
     add_custom_target(tidy-target-${TARGET})
     foreach(SOURCE ${SOURCES})
         if(NOT "${SOURCE}" MATCHES "(h|hpp|hxx)$")
-            string(MAKE_C_IDENTIFIER "${SOURCE}" tidy_file)
+            get_filename_component(SRC_ABS ${SOURCE} ABSOLUTE)
+            string(FIND ${SRC_ABS} ${CMAKE_CURRENT_BINARY_DIR} BINARY_IDX)
+            if(BINARY_IDX EQUAL -1)
+                set(tidy_file_prefix "s")
+                set(ROOT_DIR ${CMAKE_CURRENT_SOURCE_DIR})
+            else()
+                set(tidy_file_prefix "b")
+                set(ROOT_DIR ${CMAKE_CURRENT_BINARY_DIR})
+            endif()
+            get_filename_component(SRC_PATH ${SRC_ABS} DIRECTORY)
+            file(RELATIVE_PATH REL_PATH ${ROOT_DIR} ${SRC_PATH})
+            get_filename_component(BASE_SOURCE_NAME ${SOURCE} NAME_WE)
+            if(REL_PATH)
+                set(BASE_SOURCE ${REL_PATH}/${BASE_SOURCE_NAME})
+            else()
+                set(BASE_SOURCE ${BASE_SOURCE_NAME})
+            endif()
+            string(MAKE_C_IDENTIFIER "${tidy_file_prefix}/${BASE_SOURCE}" tidy_file)
             set(tidy_target tidy-target-${TARGET}-${tidy_file})
             if(CLANG_TIDY_CACHE_SIZE GREATER 0)
-                get_filename_component(SRC_ABS ${SOURCE} ABSOLUTE)
-                string(FIND ${SRC_ABS} ${CMAKE_CURRENT_BINARY_DIR} BINARY_IDX)
-                if(BINARY_IDX EQUAL -1)
-                    set(ROOT_DIR ${CMAKE_CURRENT_SOURCE_DIR})
-                else()
-                    set(ROOT_DIR ${CMAKE_CURRENT_BINARY_DIR})
-                endif()
-                get_filename_component(SRC_PATH ${SRC_ABS} DIRECTORY)
-                file(RELATIVE_PATH REL_PATH ${ROOT_DIR} ${SRC_PATH})
-                get_filename_component(BASE_SOURCE_NAME ${SOURCE} NAME_WE)
-                if(REL_PATH)
-                    set(BASE_SOURCE ${REL_PATH}/${BASE_SOURCE_NAME})
-                else()
-                    set(BASE_SOURCE ${BASE_SOURCE_NAME})
-                endif()
                 file(
                     WRITE ${CMAKE_CURRENT_BINARY_DIR}/${tidy_target}.cmake
                     "

test/analyze/CMakeLists.txt

@@ -40,11 +40,15 @@ rocm_enable_cppcheck(
         threadsafety
 )
 
+# Workaround clangTooling issue: https://github.com/llvm/llvm-project/issues/100909
+add_compile_options(-Wno-unused-command-line-argument)
+
 rocm_setup_version(VERSION 1.0.0)
 
-configure_file(simple2.cpp.in simple2.cpp)
+configure_file(simple2.cpp.in simple.cpp)
+configure_file(simple_with_a_ridiculously_long_filename_in_order_to_test_long_filenames_in_clang_tidy_cmake.cpp.in simple_with_a_ridiculously_long_filename_in_order_to_test_long_filenames_in_clang_tidy_cmake.cpp)
 
-add_library(simple simple.cpp ${CMAKE_CURRENT_BINARY_DIR}/simple2.cpp)
+add_library(simple simple.cpp ${CMAKE_CURRENT_BINARY_DIR}/simple_with_a_ridiculously_long_filename_in_order_to_test_long_filenames_in_clang_tidy_cmake.cpp ${CMAKE_CURRENT_BINARY_DIR}/simple.cpp)
 rocm_install_targets(TARGETS simple INCLUDE include)
 
 

test/analyze/include/simple.h

@@ -7,6 +7,8 @@
 #define GUARD_SIMPLE_H
 
 void simple();
+void simple2();
+void simple_long();
 
 
 #endif

test/analyze/simple.cpp

@@ -2,6 +2,7 @@
  * Copyright (C) 2017 Advanced Micro Devices, Inc.
  ******************************************************************************/
 
+#include <simple.h>
 
 void simple()
 {}

test/analyze/simple2.cpp.in

@@ -2,6 +2,7 @@
  * Copyright (C) 2020 Advanced Micro Devices, Inc.
  ******************************************************************************/
 
+#include <simple.h>
 
 void simple2()
 {}

test/analyze/simple_with_a_ridiculously_long_filename_in_order_to_test_long_filenames_in_clang_tidy_cmake.cpp.in

@@ -0,0 +1,8 @@
+/*******************************************************************************
+ * Copyright (C) 2017 Advanced Micro Devices, Inc.
+ ******************************************************************************/
+
+#include <simple.h>
+
+void simple_long()
+{}

test/test.cmake

@@ -107,7 +107,8 @@ function(configure_dir DIR)
     cmake_parse_arguments(PARSE "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
 
     string(RANDOM BUILD_RAND)
-    set(BUILD_DIR ${BUILDS_DIR}/${BUILD_RAND})
+    set(BUILD_DIR ${BUILDS_DIR}/${BUILD_RAND}/longer_pathname_so_that_rpms_can_support_packaging_the_debug_info_for_all_os_profiles/src/out/some-os-version/version/build/rocm-cmake/build)
+    # set(BUILD_DIR ${BUILDS_DIR}/${BUILD_RAND})
     if(NOT EXISTS ${BUILD_DIR})
         file(MAKE_DIRECTORY ${BUILD_DIR})
     endif()