Skip to content

Commit bb18c61

Browse files
authored
Fix Lintian warning for empty pre/post install scripts (#273)
* Lintian Warning Fix, License Folder Name Update * Prioritizing Lintian Warning Fixes * UT FIX Update * Update comments
1 parent 10155d7 commit bb18c61

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

share/rocmcmakebuildtools/cmake/ROCMCreatePackage.cmake

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -402,10 +402,6 @@ macro(rocm_create_package)
402402

403403
file(WRITE ${PROJECT_BINARY_DIR}/debian/postinst "")
404404
file(WRITE ${PROJECT_BINARY_DIR}/debian/prerm "")
405-
set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${PROJECT_BINARY_DIR}/debian/postinst;${PROJECT_BINARY_DIR}/debian/prerm")
406-
set(CPACK_RPM_POST_INSTALL_SCRIPT_FILE "${PROJECT_BINARY_DIR}/debian/postinst")
407-
set(CPACK_RPM_PRE_UNINSTALL_SCRIPT_FILE "${PROJECT_BINARY_DIR}/debian/prerm")
408-
409405
if(PARSE_LDCONFIG AND NOT ${ROCM_DISABLE_LDCONFIG})
410406
set(LDCONFIG_DIR ${LIB_DIR})
411407
if(PARSE_LDCONFIG_DIR)
@@ -417,7 +413,6 @@ macro(rocm_create_package)
417413
echo \"${LDCONFIG_DIR}\" > /etc/ld.so.conf.d/${PARSE_NAME}.conf
418414
ldconfig
419415
")
420-
421416
file(
422417
APPEND ${PROJECT_BINARY_DIR}/debian/prerm
423418
"
@@ -433,10 +428,28 @@ macro(rocm_create_package)
433428
if(PARSE_COMPONENTS)
434429
rocm_set_comp_cpackvar(PARSE_HEADER_ONLY "${PARSE_SUFFIX}" "${PARSE_COMPONENTS}")
435430
endif()
431+
432+
# Lintian Warning Fix: Enable post/pre scripts only if non empty
433+
rocm_check_and_configure_script_files("${PROJECT_BINARY_DIR}/debian/prerm" "${PROJECT_BINARY_DIR}/debian/postinst")
434+
436435
include(CPack)
437436
set(ROCM_PACKAGE_CREATED TRUE CACHE INTERNAL "Track whether rocm_create_package has been called.")
438437
endmacro()
439438

439+
# Check script File Size and then configure
440+
macro(rocm_check_and_configure_script_files PS_SCRIPT_FILE PR_SCRIPT_FILE)
441+
file(SIZE ${PS_SCRIPT_FILE} _postinst_file_sz)
442+
if(${_postinst_file_sz} GREATER 0)
443+
set(CPACK_RPM_POST_INSTALL_SCRIPT_FILE "${PS_SCRIPT_FILE}")
444+
set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${PS_SCRIPT_FILE}")
445+
endif()
446+
file(SIZE ${PR_SCRIPT_FILE} _prerm_file_sz)
447+
if(${_prerm_file_sz} GREATER 0)
448+
set(CPACK_RPM_PRE_UNINSTALL_SCRIPT_FILE "${PR_SCRIPT_FILE}")
449+
set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA};${PR_SCRIPT_FILE}")
450+
endif()
451+
endmacro()
452+
440453
macro(rocm_setup_license HEADER_ONLY)
441454
if(NOT CPACK_RESOURCE_FILE_LICENSE)
442455
file(GLOB _license_files LIST_DIRECTORIES FALSE "${CMAKE_SOURCE_DIR}/LICENSE*")

0 commit comments

Comments
 (0)