Cherry-pick PROVIDES field fixes for header-only components #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix provides field Previously the code for provides field was not evaluating the CPACK_DEBIAN_PACKAGE_PROVIDES variable, causing CPACK_DEBIAN_PACKAGE_PROVIDES to be included as a literal string provided by the devel package. * Correct debian/rpm * Fix misplaced comma * Remove version from RPM provides field --------- Co-authored-by: Eiden Yoshida <[email protected]> (cherry picked from commit d27d809)
lawruble13
changed the title
cgmb
approved these changes
Sep 7, 2024
lawruble13
merged commit 489ef56
into
ROCm:release-staging/rocm-rel-6.3
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick fix for PROVIDES field into 6.3, this is causing issues for hipstdpar as rocThrust changed the provides variable used from
CPACK_DEBIAN_PACKAGE_PROVIDEStoCPACK_DEBIAN_DEVEL_PACKAGE_PROVIDES(see rocThrust PR #369).