Skip to content

Update upper end of cmake_minimum_required range #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 10, 2025
Merged

Update upper end of cmake_minimum_required range #241

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a2ea99e
Update upper end of cmake_minimum_required range
lawruble13 Nov 22, 2024
98f7b7e
Add CMake version 3.31.0 to testing
lawruble13 Nov 22, 2024
04e08dd
Change CMP0079 behaviour
lawruble13 Nov 22, 2024
f107dd7
Update upper end of range to latest version tested (3.31.0)
lawruble13 Nov 22, 2024
1d354e9
Merge branch 'develop' into update_cmake_minimum_required_upper
lawruble13 Jan 9, 2025
61bc222
Update CMake versions in test.yml
lawruble13 Jan 16, 2025
36f0e62
Merge branch 'develop' into update_cmake_minimum_required_upper
lawruble13 Jan 16, 2025
8c86e3b
Merge branch 'develop' into update_cmake_minimum_required_upper
lawruble13 Mar 13, 2025
16bdceb
Merge branch 'develop' into update_cmake_minimum_required_upper
lawruble13 Mar 25, 2025
1d09b89
Merge branch 'develop' into update_cmake_minimum_required_upper
lawruble13 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ jobs:
- macos-12
- windows-2019
cmake-version:
- 3.20.0
- 3.10.2
- 3.31.0
- 3.22.1
- 3.16.3
exclude:
- platform: windows-2019
cmake-version: 3.10.2
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Copyright (C) 2017 Advanced Micro Devices, Inc.
################################################################################

cmake_minimum_required (VERSION 3.6)
cmake_minimum_required (VERSION 3.6...3.31.0)

set(CMAKE_INSTALL_PREFIX "/opt/rocm" CACHE PATH "")

Expand Down
2 changes: 1 addition & 1 deletion share/rocmcmakebuildtools/cmake/ROCMTest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ macro(rocm_enable_test_package NAME)
endmacro()

if(POLICY CMP0079)
cmake_policy(SET CMP0079 OLD)
cmake_policy(SET CMP0079 NEW)
endif()

add_library(rocm_test_dependencies INTERFACE)
Expand Down
2 changes: 1 addition & 1 deletion test/analyze/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(simple LANGUAGES CXX)

find_package(ROCmCMakeBuildTools)
Expand Down
2 changes: 1 addition & 1 deletion test/docsphinx/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Copyright (C) 2023 Advanced Micro Devices, Inc.
################################################################################

cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(useful LANGUAGES CXX)
# Ideally should be NONE, but GNUInstallDirs detects platform arch using try_compile
# https://stackoverflow.com/questions/43379311/why-does-project-affect-cmakes-opinion-on-cmake-sizeof-void-p
Expand Down
2 changes: 1 addition & 1 deletion test/findpackagecheck/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(findpackagecheck CXX)

message(STATUS "PKG: ${PKG}")
Expand Down
2 changes: 1 addition & 1 deletion test/libbasic/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(basic CXX)

find_package(ROCmCMakeBuildTools)
Expand Down
2 changes: 1 addition & 1 deletion test/libheaderonly/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(headeronly LANGUAGES NONE)

find_package(ROCmCMakeBuildTools)
Expand Down
2 changes: 1 addition & 1 deletion test/libprivate/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(libprivate CXX)

find_package(ROCmCMakeBuildTools)
Expand Down
2 changes: 1 addition & 1 deletion test/libsimple/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(simple CXX)

find_package(ROCmCMakeBuildTools)
Expand Down
2 changes: 1 addition & 1 deletion test/libsimple2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(simple2 CXX)

find_package(ROCmCMakeBuildTools)
Expand Down
2 changes: 1 addition & 1 deletion test/libsimplecompat/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(simple CXX)

find_package(ROCM)
Expand Down
2 changes: 1 addition & 1 deletion test/libsimpletest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(simple CXX)

find_package(ROCmCMakeBuildTools)
Expand Down
2 changes: 1 addition & 1 deletion test/libwrapper/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(test-wrapper CXX)

find_package(ROCmCMakeBuildTools)
Expand Down
2 changes: 1 addition & 1 deletion test/pass/rocm-package-setup-component.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.10)
cmake_minimum_required(VERSION 3.10...3.31.0)

use_rocm_cmake()
include(ROCMCreatePackage)
Expand Down
2 changes: 1 addition & 1 deletion test/toolchain-var/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
################################################################################


cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
find_package(ROCmCMakeBuildTools)
project(toolchain-var CXX)

Expand Down
2 changes: 1 addition & 1 deletion test/version/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Copyright (C) 2017 Advanced Micro Devices, Inc.
################################################################################

cmake_minimum_required (VERSION 3.5)
cmake_minimum_required (VERSION 3.5...3.31.0)
project(simple LANGUAGES NONE)

find_package(ROCmCMakeBuildTools)
Expand Down
Loading