Skip to content

Hint the location of dependencies #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Hint the location of dependencies #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff41a6f
Hint the location of dependencies
krzysz00 Apr 9, 2025
d99c778
Emit HINTS in find_dependency() calls
krzysz00 Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion share/rocmcmakebuildtools/cmake/ROCMInstallTargets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ function(rocm_write_package_deps CONFIG_TEMPLATE)
set(DEPENDS ${ARGN})
rocm_list_split(DEPENDS PACKAGE DEPENDS_LIST)
foreach(DEPEND ${DEPENDS_LIST})
rocm_write_package_template_function(${CONFIG_TEMPLATE} find_dependency ${${DEPEND}})
rocm_write_package_template_function(${CONFIG_TEMPLATE} find_dependency ${${DEPEND}} HINTS "\"\${PACKAGE_PREFIX_DIR}\"")
endforeach()
endfunction()

Expand Down
6 changes: 1 addition & 5 deletions share/rocmcmakebuildtools/cmake/ROCMPackageConfigHelpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ include(CMakeFindDependencyMacro OPTIONAL RESULT_VARIABLE _ROCMCMakeFindDependen
if (NOT _ROCMCMakeFindDependencyMacro_FOUND)
macro(find_dependency dep)
if (NOT \${dep}_FOUND)
set(rocm_fd_version)
if (\${ARGC} GREATER 1)
set(rocm_fd_version \${ARGV1})
endif()
set(rocm_fd_exact_arg)
if(\${CMAKE_FIND_PACKAGE_NAME}_FIND_VERSION_EXACT)
set(rocm_fd_exact_arg EXACT)
Expand All @@ -103,7 +99,7 @@ if (NOT _ROCMCMakeFindDependencyMacro_FOUND)
if(\${CMAKE_FIND_PACKAGE_NAME}_FIND_REQUIRED)
set(rocm_fd_required_arg REQUIRED)
endif()
find_package(\${dep} \${rocm_fd_version}
find_package(\${dep} \${ARGN}
\${rocm_fd_exact_arg}
\${rocm_fd_quiet_arg}
\${rocm_fd_required_arg}
Expand Down
Loading