Skip to content

Fix Lintian warning for empty pre/post install scripts #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2025
Merged

Fix Lintian warning for empty pre/post install scripts #273

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b83b072
Lintian Warning Fix, License Folder Name Update
arvindcheru Jul 14, 2025
bf7e97a
Prioritizing Lintian Warning Fixes
arvindcheru Jul 29, 2025
56c0a27
UT FIX Update
arvindcheru Jul 29, 2025
3162eb2
update comments
arvindcheru Aug 13, 2025
a09376b
REview Update Linter Fixes
arvindcheru Aug 21, 2025
4a29808
Lint Review Comment Update
arvindcheru Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions share/rocmcmakebuildtools/cmake/ROCMCreatePackage.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,10 +402,6 @@ macro(rocm_create_package)

file(WRITE ${PROJECT_BINARY_DIR}/debian/postinst "")
file(WRITE ${PROJECT_BINARY_DIR}/debian/prerm "")
set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${PROJECT_BINARY_DIR}/debian/postinst;${PROJECT_BINARY_DIR}/debian/prerm")
set(CPACK_RPM_POST_INSTALL_SCRIPT_FILE "${PROJECT_BINARY_DIR}/debian/postinst")
set(CPACK_RPM_PRE_UNINSTALL_SCRIPT_FILE "${PROJECT_BINARY_DIR}/debian/prerm")

if(PARSE_LDCONFIG AND NOT ${ROCM_DISABLE_LDCONFIG})
set(LDCONFIG_DIR ${LIB_DIR})
if(PARSE_LDCONFIG_DIR)
Expand All @@ -417,7 +413,6 @@ macro(rocm_create_package)
echo \"${LDCONFIG_DIR}\" > /etc/ld.so.conf.d/${PARSE_NAME}.conf
ldconfig
")

file(
APPEND ${PROJECT_BINARY_DIR}/debian/prerm
"
Expand All @@ -433,10 +428,28 @@ macro(rocm_create_package)
if(PARSE_COMPONENTS)
rocm_set_comp_cpackvar(PARSE_HEADER_ONLY "${PARSE_SUFFIX}" "${PARSE_COMPONENTS}")
endif()

# Lintian Warning Fix: Enable post/pre scripts only if non empty
rocm_check_and_configure_script_files("${PROJECT_BINARY_DIR}/debian/prerm" "${PROJECT_BINARY_DIR}/debian/postinst")

include(CPack)
set(ROCM_PACKAGE_CREATED TRUE CACHE INTERNAL "Track whether rocm_create_package has been called.")
endmacro()

# Check script File Size and then configure
macro(rocm_check_and_configure_script_files PS_SCRIPT_FILE PR_SCRIPT_FILE)
file(SIZE ${PS_SCRIPT_FILE} _postinst_file_sz)
if(${_postinst_file_sz} GREATER 0)
set(CPACK_RPM_POST_INSTALL_SCRIPT_FILE "${PS_SCRIPT_FILE}")
set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${PS_SCRIPT_FILE}")
endif()
file(SIZE ${PR_SCRIPT_FILE} _prerm_file_sz)
if(${_prerm_file_sz} GREATER 0)
set(CPACK_RPM_PRE_UNINSTALL_SCRIPT_FILE "${PR_SCRIPT_FILE}")
set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA};${PR_SCRIPT_FILE}")
endif()
endmacro()

macro(rocm_setup_license HEADER_ONLY)
if(NOT CPACK_RESOURCE_FILE_LICENSE)
file(GLOB _license_files LIST_DIRECTORIES FALSE "${CMAKE_SOURCE_DIR}/LICENSE*")
Expand Down