License File Folder Name Update to Package Name#274
Draft
arvindcheru wants to merge 4 commits intoROCm:developfrom
Draft
License File Folder Name Update to Package Name#274arvindcheru wants to merge 4 commits intoROCm:developfrom
arvindcheru wants to merge 4 commits intoROCm:developfrom
Conversation
cgmb
reviewed
Aug 14, 2025
Comment on lines
-475
to
+482
| DESTINATION share/doc/${_rocm_cpack_package_name} | ||
| DESTINATION share/doc/${HDRONLY_LICENSE_INSTALLDIR} |
Collaborator
There was a problem hiding this comment.
Just to be safe, can we keep the old behaviour when HDRONLY_LICENSE_INSTALLDIR is unset?
Contributor
Author
There was a problem hiding this comment.
Thank you for the comment, I tried to address in the latest patch.
There are few failures I am facing in my testing, (even without this change) somehow the folder name generated is not consistently working for all package, ex: in case multiple packages from same module, it is random taking one of package name. Trying to check this now
arvindcheru
force-pushed
the
acheruva/license_folder_nm_test
branch
from
b48a898 to
f2f71f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes: