Skip to content

Add --hip-link to target_id check #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

Add --hip-link to target_id check #275

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eafa66
Add --hip-link to target_id check
lamb-j Aug 15, 2025
d812132
Update test.yml
lamb-j Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions share/rocmcmakebuildtools/cmake/ROCMCheckTargetIds.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ function(rocm_check_target_ids VARIABLE)
foreach(_target_id ${PARSE_TARGETS})
_rocm_sanitize_target_id("${_target_id}" _result_var)
set(_result_var "COMPILER_HAS_TARGET_ID_${_result_var}")
set(CMAKE_REQUIRED_LINK_OPTIONS "--hip-link")
check_cxx_compiler_flag("-xhip --offload-arch=${_target_id}" "${_result_var}")
if(${_result_var})
list(APPEND _supported_target_ids "${_target_id}")
Expand Down
Loading