Run single and multi GPU tests in parallel and upload combined results#257
Open
Run single and multi GPU tests in parallel and upload combined results#257
Conversation
mminutoli
reviewed
Jan 20, 2026
| docker pull "$IMAGE" | ||
| - name: Run multi GPU tests | ||
| env: | ||
| GPU_COUNT: "8" |
Contributor
There was a problem hiding this comment.
shouldn't this be 4? Anyway, I think a previous patch updated run_single_gpu.py to detect the number of GPUs with rocinfo. So is there another reason to pass GPU_COUNT?
Contributor
Author
There was a problem hiding this comment.
This env variable doesn't seem to have any effect, so I'm not changing for now. There is another one in ci.yml that should be updated.
79c25c2 to
9692a0b
Compare
864887b to
165e75a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, each uploaded log represented a full test suite run (single+multi GPU). To preserve this model while enabling parallel execution, single and multi GPU tests are now run as separate parallel jobs and their results are combined before uploading.