Rocm jaxlib v0.8.0 fixdevtar#292
Open
kiran-thumma wants to merge 8 commits intorocm-jaxlib-v0.8.0from
Open
Conversation
charleshofer
requested changes
Feb 5, 2026
charleshofer
approved these changes
Feb 5, 2026
Contributor
Author
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix
packaging.version.InvalidVersionerrors during JAX wheel builds caused by ROCm version strings containing multiple+characters (e.g.,7.12.0.dev0+<sha>), which violate PEP 440 version specifier rules.Technical Details
Modified
jax_rocm_plugin/build/rocm/ci_buildto sanitizerocm_versionby replacing+with.for PEP 440 compliance:ML_WHEEL_VERSION_SUFFIXfor Bazel jaxlib buildsROCM_VERSION_EXTRAenvironment variable for plugin/pjrt wheel buildsPEP 440 local version identifiers only allow one
+character, and the local segment can only contain alphanumerics and periods. This ensures wheel versions like0.8.0+rocm7.12.0.dev0.6475192225f38160e614c71cc0543aed2be8fa03are valid.Test Plan
+(e.g.,7.12.0.dev0+6475192225f38160e614c71cc0543aed2be8fa03)Test Result
InvalidVersionerrors.instead of second+in version stringSubmission Checklist