Skip to content

Comments

Rocm jaxlib v0.8.0 fixdevtar#292

Open
kiran-thumma wants to merge 8 commits intorocm-jaxlib-v0.8.0from
rocm-jaxlib-v0.8.0-fixdevtar
Open

Rocm jaxlib v0.8.0 fixdevtar#292
kiran-thumma wants to merge 8 commits intorocm-jaxlib-v0.8.0from
rocm-jaxlib-v0.8.0-fixdevtar

Conversation

@kiran-thumma
Copy link
Contributor

Motivation

Fix packaging.version.InvalidVersion errors during JAX wheel builds caused by ROCm version strings containing multiple + characters (e.g., 7.12.0.dev0+<sha>), which violate PEP 440 version specifier rules.

Technical Details

Modified jax_rocm_plugin/build/rocm/ci_build to sanitize rocm_version by replacing + with . for PEP 440 compliance:

  1. Line 60: Sanitize when setting ML_WHEEL_VERSION_SUFFIX for Bazel jaxlib builds
  2. Line 178: Sanitize when setting ROCM_VERSION_EXTRA environment variable for plugin/pjrt wheel builds

PEP 440 local version identifiers only allow one + character, and the local segment can only contain alphanumerics and periods. This ensures wheel versions like 0.8.0+rocm7.12.0.dev0.6475192225f38160e614c71cc0543aed2be8fa03 are valid.

Test Plan

  • Build JAX wheels with dev rocm_version containing + (e.g., 7.12.0.dev0+6475192225f38160e614c71cc0543aed2be8fa03)
  • Verify jaxlib, jax-rocm7-plugin, and jax-rocm7-pjrt wheels build successfully
  • Verify wheel filenames contain sanitized version strings

Test Result

Submission Checklist

@kiran-thumma
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants