Use git_repository for XLA and JAX dependencies#311
Merged
Conversation
Ruturaj4
force-pushed
the
simplify_dep_management
branch
from
d198aaf to
768c526
Compare
Collaborator
charleshofer
left a comment
charleshofer
left a comment
There was a problem hiding this comment.
Mostly questions and nits
jax_rocm_plugin/third_party/jax/0001-Remove-nvidia_wheel_versions.patch
Outdated
Show resolved
Hide resolved
alekstheod
reviewed
Feb 17, 2026
Switch from http_archive to git_repository for pulling XLA and JAX dependencies. This eliminates the need to compute SHA256 hashes when updating to new commits. Changes: - third_party/xla/workspace.bzl: Use git_repository with commit= - third_party/jax/workspace.bzl: Use git_repository with commit=, removed patch 0006 - WORKSPACE: Remove external_deps_repository (was added by patch 0006) - build/rocm/ci_build: Remove GIT_DIR/GIT_WORK_TREE env vars that conflicted with git_repository No SHA256 computation required.
* Restore patches * Trigger CI/CD pipelinee * Fix commit * Fix patch
Ruturaj4
force-pushed
the
simplify_dep_management
branch
from
63a6790 to
0a758bb
Compare
charleshofer
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from http_archive to git_repository for pulling XLA and JAX dependencies. This eliminates the need to compute SHA256 hashes when updating to new commits.
Changes:
Submission Checklist