Add dynamic git repository, make it possible to override jax/xla deps…#315
Open
alekstheod wants to merge 1 commit intomasterfrom
Open
Add dynamic git repository, make it possible to override jax/xla deps…#315alekstheod wants to merge 1 commit intomasterfrom
alekstheod wants to merge 1 commit intomasterfrom
Conversation
… when building rocm-jax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It simplifies the CI workflows if we can override bazel dependencies through the env variables.
For instance building rocm-jax plugins and executing tests in jax upstream repo is much easier
when we can take the jax and xla commits from the jax repo and use them when calling the tests with plugin.
It provided the possibility to apply the patches automatically as well as eliminating the need for a separate checkouts.