feat(docker): add core container layer - #417
Open
mminutoli wants to merge 1 commit into
Open
Conversation
Extract Ubuntu + deadsnakes Python into a standalone core image built on public GitHub runners, reducing AMD runner usage for the OS/Python layer that has no ROCm dependency. - New Dockerfile.core-ubu24: ubuntu:24.04 + Python 3.11-3.14 - Dockerfile.base-ubu24 now derives from core instead of ubuntu - build-base-docker.yml gains build-core-image job on ubuntu-latest - build/ci_build gains build_core_dockers subcommand + fallback logic
mminutoli
force-pushed
the
feat/core-container
branch
from
May 4, 2026 23:33
1966289 to
b4273ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfile.core-ubu24containing only Ubuntu 24.04 + Python 3.11-3.14 from deadsnakes PPA, built on public GitHub runners (ubuntu-latest) to reduce AMD GPU runner usage for the OS/Python layer.Dockerfile.base-ubu24now derives from the core image instead of rawubuntu:24.04, removing its duplicated Python installation steps.build-base-docker.ymlgains abuild-core-imagejob that runs first;build-base-imagesdepends on it vianeeds:and pins the exact core image by commit SHA.build/ci_buildgains abuild_core_dockerssubcommand and fallback logic inbuild_base_dockersto build the core image on-the-fly if it's missing from GHCR.Manylinux builder images are intentionally unchanged — they require
quay.io/pypa/manylinux_2_28_x86_64for glibc ABI compatibility.