Add missing gfx1033 to gfx103 group definition in ck#5141
Merged
Conversation
1 task
illsilin
approved these changes
Mar 19, 2026
1 task
assistant-librarian Bot
pushed a commit
to ROCm/composable_kernel
that referenced
this pull request
Apr 3, 2026
Add missing gfx1033 to gfx103 group definition in ck ## Motivation Resolving PyTorch build failures when enabling builds for gfx103X-all family in TheRock. ROCm/TheRock#3763. `gfx1033` is the only failing architecture in the family and the failures point to missing support in CK. ## Technical Details PyTorch build fails with repeated error message ``` /__w/TheRock/TheRock/external-builds/pytorch/pytorch/aten/src/ATen/../../../third_party/composable_kernel/include/ck/utility/amd_buffer_addressing_builtins.hpp:33:48: error: use of undeclared identifier 'CK_BUFFER_RESOURCE_3RD_DWORD' 33 | wave_buffer_resource.config(Number<3>{}) = CK_BUFFER_RESOURCE_3RD_DWORD; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` `gfx1033` is missing from the `__gfx103__` group which results in `CK_BUFFER_RESOURCE_3RD_DWORD` never being defined for it. Adding in `gfx1033` to the missing files which should be the minimum fix to allow torch builds to pass. ## Test Plan Compile sample test file and target gfx1033 ``` ... #ifdef __HIP_DEVICE_COMPILE__ static_assert(CK_BUFFER_RESOURCE_3RD_DWORD == 0x31014000, "wrong device value"); #else static_assert(CK_BUFFER_RESOURCE_3RD_DWORD == -1, "wrong host value"); #endif ``` ## Test Result Prior to the applying patch, compilation fails with `error: use of undeclared identifier 'CK_BUFFER_RESOURCE_3RD_DWORD'` After applying patch, test file compiles successfully. ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This was referenced Apr 7, 2026
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 8, 2026
…#3137) ## Motivation - Enabling gfx103X-all wheels in TheRock is currently blocked due to PyTorch CI failures caused by a lack of `gfx1033` support in CK. ROCm/rocm-libraries#5141 resolves these issues. ## Technical Details - The aforementioned fix has been cherrypicked into the `pytorch/release/2.8/` branch of ROCm/composable_kernel - this PR bumps the `third_party/composable_kernel` branch to pick up these changes. ## Test Plan - Trigger a build and verify it passes ## Test Result - Build succeeds for `cherrypick-gfx1033-CK-support-torch2.8` branch. https://github.com/ROCm/TheRock/actions/runs/24101854403 ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 8, 2026
…#3138) ## Motivation - Enabling gfx103X-all wheels in TheRock is currently blocked due to PyTorch CI failures caused by a lack of `gfx1033` support in CK. ROCm/rocm-libraries#5141 resolves these issues. ## Technical Details - The aforementioned fix has been cherrypicked into the `pytorch/release/2.9/` branch of ROCm/composable_kernel - this PR bumps the `third_party/composable_kernel` branch to pick up these changes. ## Test Plan - Trigger a build and verify it passes ## Test Result - Build succeeds for `cherrypick-gfx1033-CK-support-torch2.9` branch. https://github.com/ROCm/TheRock/actions/runs/24101854403 ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 8, 2026
#3139) ## Motivation - Enabling gfx103X-all wheels in TheRock is currently blocked due to PyTorch CI failures caused by a lack of `gfx1033` support in CK. ROCm/rocm-libraries#5141 resolves these issues. ## Technical Details - The aforementioned fix has been cherrypicked into the `pytorch/release/2.10/` branch of ROCm/composable_kernel - this PR bumps the `third_party/composable_kernel` branch to pick up these changes. ## Test Plan - Trigger a build and verify it passes ## Test Result - Build succeeds for `cherrypick-gfx1033-CK-support-torch2.10` branch. https://github.com/ROCm/TheRock/actions/runs/24101854403 ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
1 task
vidyasagar-amd
pushed a commit
that referenced
this pull request
Apr 9, 2026
## Motivation Resolving PyTorch build failures when enabling builds for gfx103X-all family in TheRock. ROCm/TheRock#3763. `gfx1033` is the only failing architecture in the family and the failures point to missing support in CK. ## Technical Details PyTorch build fails with repeated error message ``` /__w/TheRock/TheRock/external-builds/pytorch/pytorch/aten/src/ATen/../../../third_party/composable_kernel/include/ck/utility/amd_buffer_addressing_builtins.hpp:33:48: error: use of undeclared identifier 'CK_BUFFER_RESOURCE_3RD_DWORD' 33 | wave_buffer_resource.config(Number<3>{}) = CK_BUFFER_RESOURCE_3RD_DWORD; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` `gfx1033` is missing from the `__gfx103__` group which results in `CK_BUFFER_RESOURCE_3RD_DWORD` never being defined for it. Adding in `gfx1033` to the missing files which should be the minimum fix to allow torch builds to pass. ## Test Plan Compile sample test file and target gfx1033 ``` ... #ifdef __HIP_DEVICE_COMPILE__ static_assert(CK_BUFFER_RESOURCE_3RD_DWORD == 0x31014000, "wrong device value"); #else static_assert(CK_BUFFER_RESOURCE_3RD_DWORD == -1, "wrong host value"); #endif ``` ## Test Result Prior to the applying patch, compilation fails with `error: use of undeclared identifier 'CK_BUFFER_RESOURCE_3RD_DWORD'` After applying patch, test file compiles successfully. ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
lucbruni-amd
added a commit
to ROCm/TheRock
that referenced
this pull request
Apr 13, 2026
## Motivation Update `ROADMAP.md` to reflect recently added support. ## Technical Details `gfx103X-all` builds passing for Linux/Windows: #3763 (Pytorch failing until ROCm/rocm-libraries#5141 lands) `gfx900` builds passing: #3564 `gfx90c` builds awaiting ROCm/rocm-libraries#5282 to go green ## Test Plan `gfx90c` builds to be tested (#3818) ## Test Result N/A ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
AaronStGeorge
pushed a commit
to AaronStGeorge/rocm-libraries
that referenced
this pull request
Apr 16, 2026
## Motivation Resolving PyTorch build failures when enabling builds for gfx103X-all family in TheRock. ROCm/TheRock#3763. `gfx1033` is the only failing architecture in the family and the failures point to missing support in CK. ## Technical Details PyTorch build fails with repeated error message ``` /__w/TheRock/TheRock/external-builds/pytorch/pytorch/aten/src/ATen/../../../third_party/composable_kernel/include/ck/utility/amd_buffer_addressing_builtins.hpp:33:48: error: use of undeclared identifier 'CK_BUFFER_RESOURCE_3RD_DWORD' 33 | wave_buffer_resource.config(Number<3>{}) = CK_BUFFER_RESOURCE_3RD_DWORD; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` `gfx1033` is missing from the `__gfx103__` group which results in `CK_BUFFER_RESOURCE_3RD_DWORD` never being defined for it. Adding in `gfx1033` to the missing files which should be the minimum fix to allow torch builds to pass. ## Test Plan Compile sample test file and target gfx1033 ``` ... #ifdef __HIP_DEVICE_COMPILE__ static_assert(CK_BUFFER_RESOURCE_3RD_DWORD == 0x31014000, "wrong device value"); #else static_assert(CK_BUFFER_RESOURCE_3RD_DWORD == -1, "wrong host value"); #endif ``` ## Test Result Prior to the applying patch, compilation fails with `error: use of undeclared identifier 'CK_BUFFER_RESOURCE_3RD_DWORD'` After applying patch, test file compiles successfully. ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 28, 2026
#3144) ## Motivation - Enabling gfx103X-all wheels in TheRock is currently blocked due to PyTorch CI failures caused by a lack of `gfx1033` support in CK. ROCm/rocm-libraries#5141 resolves these issues. ## Technical Details - The aforementioned fix has been cherrypicked into the `pytorch/release/2.11/` branch of ROCm/composable_kernel - this PR bumps the `third_party/composable_kernel` branch to pick up these changes. ## Test Plan - Trigger a build and verify it passes ## Test Result - Build succeeds for `cherrypick-gfx1033-CK-support-torch2.11` branch. https://github.com/ROCm/TheRock/actions/runs/24195531659/job/70624339554 - Testing Pasting offline comments from @harkgill-amd > In https://github.com/ROCm/TheRock/actions/runs/24906345786/job/72942139688 Pytorch 3.10 + release/2.11 -> Pass Pytorch 3.11 + release/2.11 -> TestNN.test_Embedding_discontiguous_cuda failed but this seems to be a known flaky test and will be disabled with ROCm/TheRock#4775 Pytorch 3.12 + release/2.11 -> Pass Pytorch 3.13 + release/2.11 -> Pass In https://github.com/ROCm/TheRock/actions/runs/25002732513/job/73225027260 Pytorch 3.14 + release/2.11 -> The failing tests here all share the same miopenStatusUnknownError message. These are the same failures as seen in the main branch run here https://github.com/ROCm/TheRock/actions/runs/24985367049 so they aren't related to my PR ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolving PyTorch build failures when enabling builds for gfx103X-all family in TheRock. ROCm/TheRock#3763.
gfx1033is the only failing architecture in the family and the failures point to missing support in CK.Technical Details
PyTorch build fails with repeated error message
gfx1033is missing from the__gfx103__group which results inCK_BUFFER_RESOURCE_3RD_DWORDnever being defined for it. Adding ingfx1033to the missing files which should be the minimum fix to allow torch builds to pass.Test Plan
Compile sample test file and target gfx1033
Test Result
Prior to the applying patch, compilation fails with
error: use of undeclared identifier 'CK_BUFFER_RESOURCE_3RD_DWORD'After applying patch, test file compiles successfully.
Submission Checklist