Skip to content

fft: change callback param from bool to enum#7892

Open
evetsso wants to merge 1 commit into
developfrom
users/evetsso/callback_enum
Open

fft: change callback param from bool to enum#7892
evetsso wants to merge 1 commit into
developfrom
users/evetsso/callback_enum

Conversation

@evetsso
Copy link
Copy Markdown
Contributor

@evetsso evetsso commented May 29, 2026

So that legacy callbacks can be described as such.

Motivation

Infrastructure to prepare for JIT callbacks.

Technical Details

run_callbacks defaulted to false prior to this change, and now defaults to a vector of enum values with no callback values. I've removed the explicit false from param generator calls for brevity.

Test Plan

Regular regression tests.

Test Result

Tests pass.

Submission Checklist

So that legacy callbacks can be described as such.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 30, 2026

Codecov Report

❌ Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
projects/rocfft/shared/fft_params.h 16.67% 12 Missing and 3 partials ⚠️
projects/rocfft/shared/rocfft_params.h 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (47.48%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7892      +/-   ##
===========================================
- Coverage    62.06%   61.66%   -0.40%     
===========================================
  Files         2088     2090       +2     
  Lines       358305   358452     +147     
  Branches     54196    54216      +20     
===========================================
- Hits        222366   221017    -1349     
- Misses      117117   118664    +1547     
+ Partials     18822    18771      -51     
Flag Coverage Δ *Carryforward flag
TensileLite 27.43% <ø> (ø) Carriedforward from ca4930e
hipBLAS 90.65% <ø> (ø) Carriedforward from ca4930e
hipBLASLt 41.27% <ø> (ø) Carriedforward from ca4930e
hipCUB 82.21% <ø> (ø) Carriedforward from ca4930e
hipDNN 86.59% <ø> (ø) Carriedforward from ca4930e
hipFFT 51.03% <ø> (+1.03%) ⬆️
hipRAND 76.12% <ø> (ø) Carriedforward from ca4930e
hipSOLVER 69.24% <ø> (ø) Carriedforward from ca4930e
hipSPARSE 85.42% <ø> (ø) Carriedforward from ca4930e
rocBLAS 48.09% <ø> (ø) Carriedforward from ca4930e
rocFFT 47.48% <15.79%> (-4.58%) ⬇️
rocRAND 57.04% <ø> (ø) Carriedforward from ca4930e
rocSOLVER 77.83% <ø> (ø) Carriedforward from ca4930e
rocSPARSE 72.68% <ø> (ø) Carriedforward from ca4930e

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
projects/hipfft/shared/fft_enums.h 32.17% <ø> (ø)
projects/rocfft/shared/fft_enums.h 0.00% <ø> (ø)
projects/rocfft/shared/rocfft_params.h 1.17% <0.00%> (ø)
projects/rocfft/shared/fft_params.h 5.29% <16.67%> (+0.11%) ⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants