[rocjitsu] DBI: Share free register searches (Refactor only) - #10992
Draft
accauble wants to merge 2 commits into
Draft
[rocjitsu] DBI: Share free register searches (Refactor only)#10992accauble wants to merge 2 commits into
accauble wants to merge 2 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
* The same search for free registers happened in LivenessAnalysis and in the TrampolineBuilder (even marked with a TODO). * This moves the searches to `analysis/free_registers`, passing the bound that made these different, and creates tests for the new file. * Refactor only.
* The `any_in_range` function was really an intersects. This adds that functionality to RegisterSet, as well as an `intersects_range`. * Moved a couple tests to the RegisterSetAnalysis test suite and added others.
accauble
force-pushed
the
users/accauble/rj-share-free-register-search
branch
from
August 31, 2026 20:57
e834428 to
d811c25
Compare
accauble
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Very similar searches for free registers were done by both LivenessAnalysis and TrampolineBuilder. This was marked with a TODO. This PR is 1) small clean up to move the searches to a new
analysis/free_registers+ tests for the new file and 2) a minor refactor that moves theany_in_rangetoRegisterSet::intersects+ tests for the new functionality.Refactor only.
Issue Tracking
Issue #8879.
Test Plan
Previous tests should work. New ones should work too.
Test Result
All tests pass.
Submission Checklist