Add flushing of perfetto buffer #1417
Open
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mradosav-amd
force-pushed
the
users/mradosav-amd/perfetto-flush
branch
from
85562ab to
f971273
Compare
dgaliffiAMD
reviewed
Oct 16, 2025
There was a problem hiding this comment.
Thanks, @mradosav-amd. Good change, I just a couple of comments and I think we should add to the CHANGELOGS.
By the way, is this for SWDEV-518817
dgaliffiAMD
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR will prevent buffer to be filled and data to be discarded.
Technical Details
In Perfetto configuration, flushing period is set to 10 seconds.
Test Plan
Trace workload which will generate larger trace than default perfetto_buffer_size, and be sure that larger trace is result of profiling.
Test Result
Without this patch, workload tracing was generating 1.2GB trace and trace result was incomplete, but with this patch, trace was 1.8GB, and trace was full.
Submission Checklist