[rocprof-systems] AMD SMI GTest integration #1418
Draft
+3,392
−1,477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjordje-amd
changed the title
added 2 commits
October 16, 2025 17:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce unit tests into the rocprof-sys project using gtest/gmock. For this purpose, the AMD SMI module has been chosen.
Technical Details
Refactor the AMD SMI code to make it unit testable. Split it into smaller modules and use templates for dependency injection in order to inject mock implementations.
Test Plan
Test Result
Submission Checklist