Check /sys/module/amdgpu for ROCk instead of lsmod #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keryell
suggested changes
May 27, 2022
keryell
left a comment
keryell
left a comment
There was a problem hiding this comment.
Thanks for the simplification.
But then I think you could just use Python code to test for the file existence instead of forking a shell.
littlewu2508
force-pushed
the
detectamdgpu
branch
from
dc2a4b5 to
f95cde2
Compare
littlewu2508
requested review from
charis-poag-amd,
dmitrii-galantsev and
oliveiradan
as code owners
In case amdgpu is builtin Closes: ROCm#102 Signed-off-by: YiyangWu <[email protected]>
littlewu2508
force-pushed
the
detectamdgpu
branch
from
f95cde2 to
fe96886
Compare
Contributor
|
Could this be reconsidered? I had to patch my rocm-smi because I'm building amdgpu into the kernel, but it works fine without that. |
Contributor
rocm-ci
pushed a commit
to ROCm/amdsmi
that referenced
this pull request
Nov 6, 2024
… as kernel built-in. Fixes ROCm/rocm_smi_lib#102 and is an updated version of ROCm/rocm_smi_lib#104 Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b Signed-off-by: Galantsev, Dmitrii <[email protected]> Reviewed-by: Galantsev, Dmitrii <[email protected]>
rocm-ci
pushed a commit
that referenced
this pull request
Nov 6, 2024
… as kernel built-in. Fixes #102 and is an updated version of #104 Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b Signed-off-by: Galantsev, Dmitrii <[email protected]> Reviewed-by: Galantsev, Dmitrii <[email protected]>
jayhawk-commits
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Aug 8, 2025
… as kernel built-in. Fixes ROCm/rocm_smi_lib#102 and is an updated version of ROCm/rocm_smi_lib#104 Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b Signed-off-by: Galantsev, Dmitrii <[email protected]> Reviewed-by: Galantsev, Dmitrii <[email protected]> [ROCm/rocm_smi_lib commit: 35c1d00]
jamescoxshannahhector18
added a commit
to jamescoxshannahhector18/rocm_smi_lib
that referenced
this pull request
Oct 10, 2025
… as kernel built-in. Fixes ROCm/rocm_smi_lib#102 and is an updated version of ROCm/rocm_smi_lib#104 Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b Signed-off-by: Galantsev, Dmitrii <[email protected]> Reviewed-by: Galantsev, Dmitrii <[email protected]>
otashow
added a commit
to otashow/rocm_smi_lib
that referenced
this pull request
Oct 12, 2025
… as kernel built-in. Fixes ROCm/rocm_smi_lib#102 and is an updated version of ROCm/rocm_smi_lib#104 Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b Signed-off-by: Galantsev, Dmitrii <[email protected]> Reviewed-by: Galantsev, Dmitrii <[email protected]>
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
… as kernel built-in. Fixes #102 and is an updated version of #104 Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b Signed-off-by: Galantsev, Dmitrii <[email protected]> Reviewed-by: Galantsev, Dmitrii <[email protected]> [ROCm/rocm_smi_lib commit: 35c1d00]
ammallya
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Nov 18, 2025
… as kernel built-in. Fixes ROCm/rocm_smi_lib#102 and is an updated version of ROCm/rocm_smi_lib#104 Change-Id: Icb3abe820bc67035b822358a1c04bd09a7c22b6b Signed-off-by: Galantsev, Dmitrii <[email protected]> Reviewed-by: Galantsev, Dmitrii <[email protected]> [ROCm/amdsmi commit: 172a3e2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #102
Signed-off-by: YiyangWu [email protected]