Skip to content

refactor: rename "bare metal" to "native host" across codebase#236

Merged
sgopinath1 merged 1 commit into
ROCm:mainfrom
shiv-tyagi:refactor/rename-bare-metal-to-native-host
May 28, 2026
Merged

refactor: rename "bare metal" to "native host" across codebase#236
sgopinath1 merged 1 commit into
ROCm:mainfrom
shiv-tyagi:refactor/rename-bare-metal-to-native-host

Conversation

@shiv-tyagi
Copy link
Copy Markdown
Member

@shiv-tyagi shiv-tyagi commented May 28, 2026

Summary

  • Replaces all occurrences of "bare metal" / "bare-metal" / BareMetal / bare_metal with the equivalent "native host" form throughout code and documentation.
  • The old term was misleading since the deployment mode works identically on VMs — "native host" accurately describes running directly on the host OS regardless of whether the underlying machine is physical or virtual.
  • Renames directories (deploy/bare-metaldeploy/native-host, test module bare_metalnative_host), Rust identifiers (BareMetalNativeHost, BareMetalFixtureNativeHostFixture), CI workflow references, and docs.

Test plan

  • cargo check passes
  • cargo fmt --check --all clean
  • CI E2E workflows validate updated paths

@shiv-tyagi shiv-tyagi force-pushed the refactor/rename-bare-metal-to-native-host branch from b2dedbf to 4652de8 Compare May 28, 2026 09:13
@shiv-tyagi shiv-tyagi marked this pull request as ready for review May 28, 2026 09:13
Copilot AI review requested due to automatic review settings May 28, 2026 09:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the native deployment mode terminology from “bare metal” to “native host” across Rust identifiers, tests, CI workflows, deployment assets, and documentation.

Changes:

  • Renames NodeSource::BareMetal, the E2E test module, and fixtures to NativeHost / native_host.
  • Updates deployment/docs paths from deploy/bare-metal and bare-metal.rst to deploy/native-host and native-host.rst.
  • Updates CI workflow names, test filters, artifact names, and release packaging references.

Reviewed changes

Copilot reviewed 30 out of 39 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
README.md Updates deployment guide link.
plans/implementation-roadmap.md Updates roadmap terminology.
docs/developer/building.rst Updates E2E test docs and commands.
docs/deployment/native-host.rst Renames deployment guide title.
docs/deployment/index.rst Updates deployment toctree entry.
deploy/native-host/spur.conf Native-host deployment example config.
deploy/native-host/setup-runner.sh Native-host runner setup script.
deploy/native-host/inference_test.py Native-host GPU inference test asset.
deploy/native-host/inference_job.sh Native-host inference job wrapper.
deploy/native-host/gpu_test.hip Native-host HIP GPU test asset.
deploy/native-host/distributed_test.py Native-host distributed PyTorch test asset.
deploy/native-host/distributed_job.sh Native-host distributed job wrapper.
deploy/native-host/deploy.sh Native-host deployment script.
deploy/native-host/cluster_test.sh Updates usage path comment.
crates/spurd/src/landlock.rs Updates isolation documentation terminology.
crates/spurctld/src/server.rs Registers nodes as NativeHost.
crates/spurctld/src/cluster.rs Updates tests to use NativeHost.
crates/spur-tests/src/native_host/ssh.rs Native-host SSH test helper.
crates/spur-tests/src/native_host/single_node/mod.rs Renames single-node fixture imports/types.
crates/spur-tests/src/native_host/single_node/lifecycle.rs Updates native-host test imports.
crates/spur-tests/src/native_host/single_node/jobs.rs Updates native-host test imports/references.
crates/spur-tests/src/native_host/single_node/container.rs Updates native-host test imports/references.
crates/spur-tests/src/native_host/multi_node/scheduling.rs Updates native-host test imports.
crates/spur-tests/src/native_host/multi_node/mod.rs Renames multi-node fixture imports/types.
crates/spur-tests/src/native_host/multi_node/dispatch.rs Updates native-host test imports.
crates/spur-tests/src/native_host/multi_node/container.rs Updates native-host test imports.
crates/spur-tests/src/native_host/mod.rs Renames shared fixture type references.
crates/spur-tests/src/native_host/gpu/single_node.rs Updates native-host GPU test imports.
crates/spur-tests/src/native_host/gpu/multi_node.rs Updates native-host GPU test imports.
crates/spur-tests/src/native_host/gpu/mod.rs Renames GPU fixture imports/types.
crates/spur-tests/src/native_host/fixture.rs Renames fixture type/helper and deploy path.
crates/spur-tests/src/native_host/config.rs Updates config documentation terminology.
crates/spur-tests/src/lib.rs Exposes native_host test module.
crates/spur-k8s/src/heartbeat.rs Updates comment terminology.
crates/spur-core/src/node.rs Renames NodeSource variant and docs.
crates/spur-core/src/config.rs Updates isolation config documentation terminology.
.github/workflows/release.yml Updates packaged config path.
.github/workflows/nightly.yml Updates nightly packaged config path.
.github/workflows/e2e.yml Renames native-host E2E workflow job, paths, commands, and artifact.
Comments suppressed due to low confidence (1)

docs/deployment/native-host.rst:2

  • This title is longer than its reStructuredText underline, which causes Sphinx/docutils to warn that the title underline is too short. Extend the underline to at least the title length after the rename.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/developer/building.rst Outdated
Comment thread crates/spur-core/src/node.rs
Comment thread plans/implementation-roadmap.md Outdated
The "bare metal" terminology was misleading since the deployment mode
works equally well on VMs. "Native host" accurately conveys running
directly on the host OS regardless of whether it's physical or virtual.

Renames directories, modules, enum variants, struct names, config keys,
CI workflow references, and documentation.
@shiv-tyagi shiv-tyagi force-pushed the refactor/rename-bare-metal-to-native-host branch from 4652de8 to de5e659 Compare May 28, 2026 09:29
Copy link
Copy Markdown
Collaborator

@sgopinath1 sgopinath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgopinath1 sgopinath1 merged commit ed2e08b into ROCm:main May 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants