Fix missing Protobuf well-known types in Dockerfile.manylinux#67
Open
shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
Open
Fix missing Protobuf well-known types in Dockerfile.manylinux#67shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
Conversation
I tried building this image today. It failed with a similar error like that in ROCm#61. This got missed in my previous PR because my fork was not updated with the latest commits which added this file. This PR should fix the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried building the
Dockerfile.manylinuximage today. It failed with a similar error like that in #61.This got missed in my previous PR because my fork was not updated with the latest commits which added this file.
This change should fix the issue.