fix(spur-k8s): convert millicore CPU quantities to whole cores in node allocatable#68
Open
shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
Open
fix(spur-k8s): convert millicore CPU quantities to whole cores in node allocatable#68shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
shiv-tyagi wants to merge 1 commit intoROCm:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of a node advertising CPUs in millicores (due to system reservations resulting in partially allocatable cores, for example), we are advertising 0 cores for the node.
The correct behaviour should be to report maximum available whole cores for that node (spur/slurm work on CPU whole cores).
Why not the next whole number instead of the floored value?
We should not promise more than what is available. Hence the most correct value is the floor of partial allocatable cores (e.g. 3 for 3800m)
I have verified that the changes work as expected.
Relevant tests are also included in this PR. PTAL. Thanks.