[AMD] Add Gluon GEMM tutorial#930
Merged
mengfei-jiang merged 0 commit intoROCm:gluon_extfrom Mar 13, 2026
Merged
Conversation
73d7cb2 to
51c5544
Compare
| 2. using the amd extensions, mostly gl.amd.cdna3/4.xxx | ||
|
|
||
| ### extensions | ||
| 1. instruction scheduling related |
There was a problem hiding this comment.
since they are all not fully respect, we cover it here
|
|
||
| shared_a: gl.constexpr = gl.PaddedSharedLayout( | ||
| interval_padding_pairs=[[512, 16]], | ||
| offset_bases=[ |
There was a problem hiding this comment.
make the bases short instead of multiple lines to ease user.
| # Two sched_barrier(0x0) calls define a hard scheduling region: | ||
| # no instructions may move in or out. | ||
| # | ||
| # Mask values (combinable via bitwise OR): |
There was a problem hiding this comment.
better to have it in triton _init.py or readme,
|
|
||
|
|
||
| ## Triton prepare | ||
| 1. git cherry-pick tip commits from [gluon_ext](https://github.com/ROCm/triton/tree/gluon_ext). |
There was a problem hiding this comment.
also need to rebase it, so we can make gluon_ext clean.
5f507d5 to
e563ef2
Compare
e563ef2 to
e070bbe
Compare
2bfd3e3 to
b14a6fd
Compare
4044fa2 to
b14a6fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.
Complete the following tasks before sending your PR, and replace
[ ]with[x]to indicate you have done them.I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end teststhis is a tutorial.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)