-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Update Vulkan Memory Allocator to 3.2.1 #16923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Xphalnos
commented
Mar 25, 2025
- Vulkan Memory Allocator Update from 2.3.0 (2019) to 3.2.1 (2025)
- May provide better support for Vulkan 1.4
- This may likely improve performance on less powerful machines
The reason why it wasn't updated so far is because it requires more work than just updating the library and the API Adding @kd-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically don't allow contributors outside core members to update source-only deps for obvious reasons.
Maybe we should make this a submodule instead.
Ftr - no performance or behavioural change is expected, with the exception of maybe worse performance. We tuned the previous version ourselves and upstreamed the optimizations which is why we're on some ancient version where behavior is guaranteed. All that would need to be re-vetted across multiple vendor hardware due to the differences in alignment constraints.
I applied the optimizations you made in this PR. Are there any other optimizations you made? |
+1 for submodule instead of having the header directly here |
I'll make a submodule out of this (without updating) |
Otherwise this is not really maintainable |
This needs to be rebased since we now use a submodule |
this PR seems to be related to #13045 |
if the optimizations made on the currently used customized Vulkan Memory Allocator (2.3.0) are only those provided in #9738 then they have been also merged on official repo https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator in 2021/02/16 and kd-11/rpcs3 added on project's white list. I also tested the current master of vk. mem. alloc. 3.2.1 (minor changes compared to this PR (it is the tagged version)) and it seems properly working with rpcs3 at least as the currently used custom 2.3.0. |