Skip to content

Logitech G27 fixes and cleanups #17170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Kethen
Copy link
Contributor

@Kethen Kethen commented May 5, 2025

Kethen added 2 commits May 6, 2025 01:26
- revamp effect direction to avoid some windows driver issues
	- ref: libsdl-org/SDL#7941
- fix possible SDL_SetJoystickLED calls on closed joystick handle
- revamp ramp and variable effects
- various comment cleanups
@Megamouse Megamouse added the Input label May 6, 2025
@Kethen Kethen requested a review from Megamouse May 6, 2025 11:19
@Megamouse
Copy link
Contributor

can you remove those two functions since they seem to be unused?

static inline u16 axis_to_logitech_g27_steering(s16 axis)
{
	const u16 unsigned_axis = axis + 0x8000;
	return (unsigned_axis * (0xFFFF >> 2)) / 0xFFFF;
}

static inline u8 axis_to_logitech_g27_pedal(s16 axis)
{
	const u16 unsigned_axis = axis + 0x8000;
	return (unsigned_axis * (0xFF)) / 0xFFFF;
}

axis_to_logitech_g27_steering
axis_to_logitech_g27_pedal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants