Skip to content

Conversation

Niram7777
Copy link
Contributor

Fix build error, the Triple constructor is not implicit anymore.

llvm/llvm-project@fff720d#diff-5008de5706b85963c456532be4d2e8c5b478959be9d315f77c338946bd1fc586R353-R354

[marin@pc-linux ~]$ clang++ --version
clang version 22.0.0git (https://github.com/llvm/llvm-project.git 1669bd3ae9af0cac4414479d8f1e53e329fa3efb)

@Niram7777
Copy link
Contributor Author

The Triple constructors only exist in llvm/llvm-project@fff720d#diff-5008de5706b85963c456532be4d2e8c5b478959be9d315f77c338946bd1fc586R353-R354
We can reopen the PR once we upgrade LLVM

@Niram7777 Niram7777 closed this Aug 3, 2025
@AniLeo
Copy link
Member

AniLeo commented Aug 3, 2025

You can also leave it up as draft

@Niram7777 Niram7777 reopened this Aug 6, 2025
@Niram7777 Niram7777 marked this pull request as draft August 6, 2025 09:47
@qurious-pixel
Copy link
Contributor

Is it possible to use ifdefs in the style of minimum version to build LLVM 19 and LLVM 21?

	auto null_mod = std::make_unique<llvm::Module>("null_", *m_context);
#if LLVM_VERSION_MAJOR > 20
	null_mod->setTargetTriple(llvm::Triple(jit_compiler::triple1()));
#else
	null_mod->setTargetTriple(jit_compiler::triple1());
#endif

This fixes the compilation error for LLVM triple on Windows Msys2 clang64 when wrapping all the explicit Triples.

@elad335
Copy link
Contributor

elad335 commented Oct 4, 2025

Is it possible to use ifdefs in the style of minimum version to build LLVM 19 and LLVM 21?

	auto null_mod = std::make_unique<llvm::Module>("null_", *m_context);
#if LLVM_VERSION_MAJOR > 20
	null_mod->setTargetTriple(llvm::Triple(jit_compiler::triple1()));
#else
	null_mod->setTargetTriple(jit_compiler::triple1());
#endif

This fixes the compilation error for LLVM triple on Windows Msys2 clang64 when wrapping all the explicit Triples.

@qurious-pixel yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants