Skip to content

Fix #1720 #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
+8 −11
Open

Fix #1720 #1722

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8598b48
Fix crafting recipe with multiple items in the same slot not imported…
Pirulax Jul 6, 2025
9140070
Improve for loop
Pirulax Jul 6, 2025
29f339e
Fix code, use non-deprecated method
Pirulax Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions common/logisticspipes/proxy/recipeproviders/LogisticsCraftingTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package logisticspipes.proxy.recipeproviders;

import net.minecraft.item.ItemStack;
import logisticspipes.utils.tuples.Pair;

import net.minecraft.tileentity.TileEntity;

import logisticspipes.blocks.crafting.LogisticsCraftingTableTileEntity;
Expand Down Expand Up @@ -31,19 +32,15 @@ public boolean importRecipe(TileEntity tile, IItemIdentifierInventory inventory)
return false;
}

// Craft result is slot 9
inventory.setInventorySlotContents(9, result);

// Import
for (int i = 0; i < bench.matrix.getSizeInventory(); i++) {
if (i >= inventory.getSizeInventory() - 2) {
break;
}
ItemStack stackInSlot = bench.matrix.getStackInSlot(i);
if (!stackInSlot.isEmpty() && stackInSlot.getCount() > 1) {
stackInSlot = stackInSlot.copy();
stackInSlot.setCount(1);
// Import (Slots [0, 8])
for (Pair<ItemIdentifierStack, Integer> slot : bench.matrix) {
final int i = slot.getValue2();
if (i <= inventory.getSizeInventory() - 2) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not exactly sure why inventory size - 2 would be okay here in the new code, but not previously? Can you elaborate?

inventory.setInventorySlotContents(i, slot.getValue1().makeNormalStack());
}
inventory.setInventorySlotContents(i, stackInSlot);
}

if (!bench.isFuzzy()) {
Expand Down