Deduplicate rsyslog events#30
Open
dougszumski wants to merge 1 commit into
Open
Conversation
This isn't recommended, but we can use it if we hit performance issues.
JohnGarbutt
approved these changes
Mar 18, 2019
JohnGarbutt
left a comment
JohnGarbutt
left a comment
Collaborator
There was a problem hiding this comment.
This seems good actually. Why did we say its not recommended now?
My previous object was the notifications, but actually I think we get told what count of logs were suppressed, so we are probably OK.
Collaborator
Author
|
Yeah, I guess I'm a little scared that the count of suppressed logs might break a regex which would otherwise match, for example in mtail. Maybe alert-manager should do the suppression? I will investigate this a little more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't recommended, but we can use it if we hit performance issues.