release(mobile): Release v0.4.1 - #4952
Conversation
release(desktop): Release v1.4.0
chore(sync): merge main and mobile-main into dev
Bumps [nick-fields/retry](https://github.com/nick-fields/retry) from 3 to 4. - [Release notes](https://github.com/nick-fields/retry/releases) - [Commits](nick-fields/retry@v3...v4) --- updated-dependencies: - dependency-name: nick-fields/retry dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cae21c1c4b
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export const fetchRsshubAnalysis = () => { | ||
| return followClient.api.discover.rsshubAnalytics({}) |
There was a problem hiding this comment.
This change drops the lang parameter entirely in fetchRsshubAnalysis, so analytics are always fetched as global data even when the user selected a specific discover language; downstream ranking/heat calculations then combine language-filtered route lists with unfiltered analytics, producing inconsistent ordering and counts for non-default languages. Pass the selected language through to rsshubAnalytics (or remove language-dependent query keys if the endpoint truly no longer supports it).
Useful? React with 馃憤聽/ 馃憥.
| switch (value) { | ||
| case "Lax": { | ||
| return "lax" as const | ||
| } | ||
| case "Strict": { | ||
| return "strict" as const | ||
| } | ||
| case "None": { | ||
| return "no_restriction" as const |
There was a problem hiding this comment.
The parser only accepts Lax/Strict/None with exact casing, but Set-Cookie attribute values are case-insensitive and many servers emit lowercase variants (for example samesite=none); in those cases sameSite is dropped and Electron falls back to a default policy, which can prevent auth cookies from being sent cross-site and break desktop sign-in/TOTP cookie persistence. Lowercase the value before switching.
Useful? React with 馃憤聽/ 馃憥.
2 participants
v0.4.1