Skip to content

Conversation

@ArcTanSusan
Copy link

Also remove reference to prod log server in instructions for setting up
local dev environment.

test/wdio.ci.js Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'console' is not defined.

@ultrasaurus
Copy link
Contributor

Love the new content in getting set up and overall am very positive about README changes.

I don't understand the benefits of this syntax which used to be there:

```sh

@yoz @shawnbot ?

Also, not sure I'm crazy about the shell script that people have to modify -- for me, I always then risk checking it in by mistake. I prefer something like using the dotenv gem... maybe move that to separate issue/PR for discussion

@shawnbot
Copy link
Contributor

Yeah, I would prefer that we recommend a tool such as autoenv to manage automatically setting environment variables, rather than the shell script.

Also remove reference to prod log server in instructions for setting up
local dev environment.
Introduce the idea of using autoenv in README. Much easier to run a .env than to manually set env variables on a command line.
@ArcTanSusan
Copy link
Author

@shawnbot @ultrasaurus I've addressed the feedback in this updated PR. Feel free to review this again. 🐰

@shawnbot
Copy link
Contributor

shawnbot commented Jan 7, 2016

Thanks, @onceuponatimeforever! I'm assigning this to @ultrasaurus to review the actual content changes, since I'm less familiar with that process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants