Skip to content

updated deps & datastore needs Sync#14

Open
jrapoport wants to merge 1 commit intoRTradeLtd:masterfrom
jrapoport:datastore-sync
Open

updated deps & datastore needs Sync#14
jrapoport wants to merge 1 commit intoRTradeLtd:masterfrom
jrapoport:datastore-sync

Conversation

@jrapoport
Copy link

updated deps.

Datastore interface no requires Sync method. returning nil as a no-op is fine and what MapDatastore does:
https://github.com/ipfs/go-datastore/blob/123d227a8d53b7e5d5c59c86b64efdeccb9dcc2f/basic_ds.go#L33

func (d *Datastore) Sync(_ datastore.Key) error {
	return nil // no-op
}

@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #14 (a08e252) into master (a2ca263) will decrease coverage by 2.90%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   84.38%   81.49%   -2.89%     
==========================================
  Files           1        1              
  Lines          64       54      -10     
==========================================
- Hits           54       44      -10     
  Misses          7        7              
  Partials        3        3              
Impacted Files Coverage Δ
datastore.go 81.49% <0.00%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ca263...a08e252. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant