Fix IO-Path handling breaks in installation (e g. pip install ...) (#126)#127
Open
PSeros wants to merge 1 commit into
Open
Fix IO-Path handling breaks in installation (e g. pip install ...) (#126)#127PSeros wants to merge 1 commit into
PSeros wants to merge 1 commit into
Conversation
Result paths in Datahandler, DemandPlots, and CertificateBuilder defaulted to a directory inside the package source tree, which is read-only in a pip-installed environment. They now default to os.getcwd()/results. load_global_config no longer requires .env files to live inside the package's data/ directory. Relative paths resolve against CWD first, with the bundled data/ directory as a fallback so existing examples keep working unchanged. Passing None now returns class defaults without touching the filesystem. The now-unused Settings class is removed. setup.py explicitly declares package_data so the data/ directory and all its contents are reliably included in the distribution.
Author
|
I forgot that deleting the branch closes the pull request... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result paths in
Datahandler,DemandPlots, andCertificateBuilderdefaulted to a directory inside the package source tree, which should be read-only. They now default toos.getcwd()/results(this doesn't change the current behaviour when cloning the repository).load_global_configno longer requires.envfiles to live inside the package'sdata/directory. Relative paths resolve against CWD first, with the bundleddata/directory as a fallback so existing examples keep working unchanged. Passing None now returns class defaults without touching the filesystem. The now-unused Settings class is removed.Additionally
setup.pyexplicitly declarespackage_dataso thedata/directory and all its contents are reliably included in the distribution.