Задание на проверку ТГ: @my4kish #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asylbekovkairat
suggested changes
Dec 29, 2024
src/app/header/header.component.html
Outdated
| @@ -0,0 +1,19 @@ | |||
| <mat-toolbar class="header"> | |||
| <!-- <button mat-icon-button class="example-icon" aria-label="Example icon-button with menu icon"> | |||
src/app/users-api.service.ts
Outdated
| import { HttpClient } from "@angular/common/http"; | ||
| import { inject, Injectable } from "@angular/core"; | ||
|
|
||
| @Injectable({providedIn: 'root'}) |
| readonly data = inject(MAT_DIALOG_DATA) | ||
| readonly dialogRef = inject(MatDialogRef<CreateEditUserDialogComponent>); | ||
|
|
||
| // @Output() |
| standalone: true, | ||
| }) | ||
| export class CreateEditUserDialogComponent{ | ||
| readonly data = inject(MAT_DIALOG_DATA) |
There was a problem hiding this comment.
добавьте модификаторы доступа private или public
| export const UsersActions = createActionGroup({ | ||
| source: 'Users', | ||
| events: { | ||
| 'set': props<{users: User[]}>(), |
There was a problem hiding this comment.
можно убрать кавычки для ключей объекта, так как все они целые слова
| private readonly usersApiService = inject(UsersApiService); | ||
| private readonly dialog = inject(MatDialog); | ||
| private isEdit: Boolean = false; | ||
| private readonly store = inject(Store); |
There was a problem hiding this comment.
инжектирование зависимостей пишите выше
| } | ||
|
|
||
| public openDialog(user?: User): void { | ||
| this.isEdit = user !== undefined |
There was a problem hiding this comment.
вручную прописывать undefined является плохой практикой, лучше null или же в вашем случае false, потому что переменная назвалась через is
| } | ||
| }); | ||
|
|
||
| dialogRef.afterClosed().subscribe(result => { |
| ); | ||
| } | ||
|
|
||
| public editUser(user: any) { |
src/styles.scss
Outdated
| display: block; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
удалите все комментарии и лишние пустые строки
asylbekovkairat
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ТГ: @my4kish