[codex] support OAuth client id negotiation#277
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_id_metadata_document_supportedin authorization server metadata and add coverage to OAuth/MCP tests./oauth/authorize?requestId=...through login so unauthenticated HTTP MCP authorization returns to the consent page instead of/home.Why
Some MCP/OAuth clients begin authorization with a stable
client_idbefore dynamic registration. Previously those requests failed withinvalid_client, including native clients using custom redirect schemes.Unauthenticated users could also lose the original authorization target during login and land on the app home page, which prevented the OAuth consent step from appearing.
Validation
cd server && bun run lintcd server && bun run buildcd server && POSTGRESQL_URL=postgresql://rote:rote_password_123@localhost:5433/rote TEST_BASE_URL=http://127.0.0.1:3004 bun run tests/oauth-mcp.test.tscd web && bun run lintcd web && bun run build/oauth/authorize?requestId=...redirected to/login?redirect=...; after login it returned to/oauth/authorize?requestId=...and displayed拒绝/允许.