Add support for image/svg+xml - #143
Open
blmarket wants to merge 2 commits into
Open
Conversation
This change allows SVG images can be processed by astro-imagetools. (e.g. converting svg into webp etc) As the `file-type` library parse the SVG image as 'xml' extension, we should add `xml` to supportedImageTypes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
FWIW: My workaround currently is to not process SVG files because in most cases they are smaller in file size than pixel-based image files. But having an option to optimize them using SVGO would be rad. |
Owner
|
Nice contribution @blmarket, definitely a great addition ! But I agree with @stephanbogner. @blmarket what do you think? Could you please update the PR? I'll be glad to work on this together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows SVG images can be processed by astro-imagetools. (e.g. converting svg into webp etc)
As the
file-typelibrary parse the SVG image as 'xml' extension, we should addxmlto supportedImageTypes.