Fix for #180, where file format missing from src attr on <Img> component. - #182
Open
bnjmnrsh wants to merge 1 commit into
Open
Fix for #180, where file format missing from src attr on <Img> component.#182bnjmnrsh wants to merge 1 commit into
bnjmnrsh wants to merge 1 commit into
Conversation
…<Img> component.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #180, the
<Img>component does not include a file format extension onto the file path of the src attribute. Browsers will render the image anyway as the correct path is included in thesrcsetattr. However, the current state is invalid, resulting in a 404 being thrown in both dev and prod.While this PR works as intended and addresses the issue, it may be better to forward the
formatproperty to/api/renderImage.jsand do the concatenation there, as this is where the rest of the data manipulation occurs. However, that PR would affect more than one file, so this is a minimal proof of concept.