Skip to content

Conversation

@Ivan-Johnson
Copy link
Contributor

@Ivan-Johnson Ivan-Johnson commented Dec 20, 2025

@Rahix, I've got a couple of questions:

  1. Should we define default_serial?

    Given the fact that the ATmega32U4 doesn't have a hardware serial, my gut reaction is that we don't need it. However, both of the existing ATmega32U4 boards do define default_serial. Am I incorrect in assuming that default_serial is used for the default hardware serial bus?

  2. Other than verifying that the new arduino-micro examples work (they do), are there any other tests that you'd like me to run?

    In particular: when I try running cargo build from the root directory, I get a ton of build errors. I get the same errors even without this PR applied (build_logs.txt). Is this an issue with my build environment, or is cargo build only expected to work when run from within an example package?

Ivan-Johnson added a commit to Ivan-Johnson/Custom-Game-Controller that referenced this pull request Dec 20, 2025
@Rahix
Copy link
Owner

Rahix commented Dec 20, 2025

Thanks for picking this up!

Should we define default_serial?

Yeah, I think we still should do it. You can connect a separate USB-UART bridge to the RX/TX pins to talk to the board so it is nice to have the short-hand macro for setting up communication.

Other than verifying that the new arduino-micro examples work (they do), are there any other tests that you'd like me to run?

No, this is entirely fine. Running cargo build from the crate root is expected to fail, you must run it from inside each directory. But in the end, just let the CI run those build tests for you ;)

@Ivan-Johnson
Copy link
Contributor Author

You can connect a separate USB-UART bridge to the RX/TX pins to talk to the board

Ah, that makes sense; I didn't realize until now that UART only works on those two pins in particular.

I've pushed an update that enabled default_serial. I don't have easy access to a USB-UART bridge of my own, but I have created an micro-usart.rs so that we can at least verify that it compiles successfully. I assume that's good enough; as best I can tell the Arduino Micro and Arduino Leonardo hardware boards are essentially identical aside from their physical sizes

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! :)

@Rahix Rahix merged commit ff4909c into Rahix:main Dec 20, 2025
28 checks passed
@Ivan-Johnson Ivan-Johnson deleted the arduino-micro branch December 21, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants