arduino-hal: Add support for Arduino Micro #693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Rahix, I've got a couple of questions:
Should we define
default_serial?Given the fact that the ATmega32U4 doesn't have a hardware serial, my gut reaction is that we don't need it. However, both of the existing ATmega32U4 boards do define
default_serial. Am I incorrect in assuming thatdefault_serialis used for the default hardware serial bus?Other than verifying that the new
arduino-microexamples work (they do), are there any other tests that you'd like me to run?In particular: when I try running
cargo buildfrom the root directory, I get a ton of build errors. I get the same errors even without this PR applied (build_logs.txt). Is this an issue with my build environment, or iscargo buildonly expected to work when run from within an example package?