Add files from other repository #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsbndrnk
reviewed
Oct 31, 2021
| public ResponseEntity<Integer> getSocks(@RequestParam String color, | ||
| @RequestParam String operation, | ||
| @RequestParam int cottonPart) { | ||
| if (cottonPart < 0 || cottonPart > 100) |
vsbndrnk
reviewed
Oct 31, 2021
| Sock sock = sockRepository | ||
| .findByColorAndCottonPart(color, sockModel.getCottonPart()) | ||
| .orElseThrow(NotEnoughSocksException::new); | ||
| if (sock.getQuantity() < sockModel.getQuantity()) |
There was a problem hiding this comment.
я бы так исключениями не увлекался - это дорого и медленно, а например ситуация когда нет нужного числа носков. -вполне штатная. поэтому тут лучше либо ответ с результатом операции, который маппится в http, либо в сервисе не хранить тяжелую логику, а переложить ее на контроллер.
В целом тут два варианта - либо сервис возвращает сложный формат ответа, включающий ошибки и их описание, либо контроллер у себя логику всю считает - оба валидные
vsbndrnk
reviewed
Oct 31, 2021
| private final ColorRepository colorRepository; | ||
| private final SockRepository sockRepository; | ||
|
|
||
| public int addSocks(@NotNull SockModel sockModel) { |
vsbndrnk
reviewed
Oct 31, 2021
|
|
||
| int quantity = switch (operation) { | ||
| case "moreThan" -> sockRepository | ||
| .findByColorAndCottonPartGreaterThan(color, cottonPart) |
There was a problem hiding this comment.
тут ради одной цифры тащить целый объект не оптимально
vsbndrnk
reviewed
Oct 31, 2021
| package com.example.socks; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.boot.test.context.SpringBootTest; |
There was a problem hiding this comment.
С поставленной задачей справился, есть недочеты или спорные моменты - они есть всегда и везде, главное, что решение валидно.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.