Task done!) #172
Open
Task done!) #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Optional<Integer> getSocksMoreThan(String color, int cottonPart); | ||
|
|
||
| @Query("SELECT SUM (socks.quantity) FROM Socks AS socks WHERE socks.color = :color AND socks.cottonPart < :cottonPart") | ||
| Optional<Integer> getIdByColorAndCottonPart(String color, int cottonPart); |
There was a problem hiding this comment.
название метода не совпадают с запросом. может перепутал первый и последний?
| } | ||
|
|
||
| public void income(SocksDto socksDto) { | ||
| Optional<Integer> id = socksRepository.getIdByColorAndCottonPart(socksDto.getColor(), socksDto.getCottonPart()); |
There was a problem hiding this comment.
лишний запрос id, а потом объект по этому id. можно было бы сразу вытащить объект и его использовать
|
|
||
| public int getAll(String color, String operation, int cottonPart) { | ||
| Optional<Integer> count = switch (operation) { | ||
| case "moreThan" -> socksRepository.getSocksMoreThan(color, cottonPart); |
There was a problem hiding this comment.
operation можно сделать enum, будет меньше ошибок
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Тесты не сделал, т.к. не очень понимаю как их делать, на курсе обучения мельком их захватывали. С докером знаком, но с H2, в данном задании, думаю, он особо не нужен, а с Heroku уже времени нет разбираться - дедлайн. Всё же постарался сделать так, чтобы было максимально современно и поменьше кода, настолько, насколько знаю про разработку)