feature: batch mapper #1854
Open
feature: batch mapper #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of the conversation here: https://github.com/orgs/RailsEventStore/discussions/1847
A small chance is made to how event store invokes the mapper for reading events. By default it will still handle each event one by one, but it does that now inside the mapper, instead of the
Specification::Reader. This provides a hook for developers to do some batch work on their mappers (eg: preloading encryption keys).Thins to consider, improve:
map_records_to_eventsmethodSpecificationReadershows up only once in an application, but during tests it shows up a lot.