192 make global context mutable#196
Merged
Merged
Conversation
soulFood5632
requested changes
Jun 17, 2025
soulFood5632
left a comment
soulFood5632
left a comment
Member
There was a problem hiding this comment.
Looks good. I don't see how you exposed the put method to the user.
soulFood5632
requested changes
Jun 17, 2025
soulFood5632
left a comment
soulFood5632
left a comment
Member
There was a problem hiding this comment.
Sorry I should reviewed more completely last time. We should defintely have tests for this to make sure that the put method is working as expected. Specifically in the integration tests (not unit tests).
mbrailtown
self-requested a review
July 13, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR that adjusts the global context to be mutable. Really not much else to it, adds implementation for
put, and replacesdefinewithupdateto better reflect functionality.