Port crash fixes and install scripts from cycloarcane/stability-fixes-and-install#7
Open
cycloarcane wants to merge 1 commit intoRainyPixel:mainfrom
Open
Port crash fixes and install scripts from cycloarcane/stability-fixes-and-install#7cycloarcane wants to merge 1 commit intoRainyPixel:mainfrom
cycloarcane wants to merge 1 commit intoRainyPixel:mainfrom
Conversation
…-and-install - TTYSwitchMonitor: replace qFatal with qWarning so D-Bus failures degrade gracefully instead of killing plasmashell (fix RainyPixel#1) - install.sh / uninstall.sh: new one-shot scripts for Arch, Debian, Fedora and openSUSE; adds sndio to Arch deps (required by libmpv); uninstaller uses kpackagetool6 with rm fallback (fixes RainyPixel#3 and RainyPixel#4) - .gitmodules: repoint backend_scene submodule back to RainyPixel/wallpaper-scene-renderer (removes CaptSilver dependency) - submodule: reset to RainyPixel renderer HEAD (70ce49c); particle crash fix (fix RainyPixel#2) is pending merge of RainyPixel/wallpaper-scene-renderer#1 Ported from catsout/wallpaper-engine-kde-plugin#573 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the fixes from cycloarcane/wallpaper-engine-kde-plugin PR #573 upstream.
Changes
Fix 1 — TTYSwitchMonitor: qFatal → qWarning
On systems where D-Bus is unavailable or slow at startup, the two
qFatal()calls inTTYSwitchMonitorwould callabort()and kill plasmashell immediately. Replaced withqWarning()so the plugin degrades gracefully with sleep/wake detection disabled.Fix 3 & 4 — install.sh / uninstall.sh
New one-shot install and uninstall scripts supporting Arch, Debian/Ubuntu, Fedora, and openSUSE. The Arch dependency list includes
sndio, which is required bylibmpvon Arch (without it the plugin fails to load with a missing-library error in the journal).Submodule cleanup
Repoints
.gitmodulesback toRainyPixel/wallpaper-scene-renderer(removes the dependency on the third-partyCaptSilverfork).Pending
Fix 2 — Particle wallpaper crash
A separate PR has been opened against your scene renderer:
👉 RainyPixel/wallpaper-scene-renderer#1
Certain particle wallpapers (e.g. workshop item 2609314607) cause a
std::out_of_rangeexception inSpriteAnimation::GetCurFramewhich propagates uncaught throughLoadMaterialand hitsstd::terminate. Once that renderer PR is merged the submodule pointer here can be bumped to include it.Fix 5 — NO TEXT badge
The original Python backend had a
analyse_pkgfunction that detected text objects in.pkgfiles and showed a warning badge in the wallpaper picker. Since this fork replaced Python with native C++, this needs reimplementing as aFileHelper::analysePkg()method. Will follow up in a separate PR.Test plan
./install.sh --skip-restartcompletes without errorssndiois pulled in and plugin loads (journalctl /usr/bin/plasmashellshows no missing-library errors)./uninstall.sh --yesremoves the plugin cleanly🤖 Generated with Claude Code