Open
Conversation
FolderDialog.selectedFolder is a QUrl; calling .toString() produced 'file:///path' which was stored directly in cfg_SteamLibraryPath. Use Common.urlNative() to strip the file:// prefix before storing, so KConfig gets a clean native path matching the Path type semantics. Also fix unreferenced variable in utils.mjs dirname() (dead code).
loadFolderLists() crashed with TypeError when getFolderList() returned
an empty object {} for non-existent directories (e.g. myprojects).
The check 'if(!folder)' did not catch empty objects since {} is truthy.
This crashed the forEach loop before the model could be populated,
causing 0 wallpapers to be shown despite valid workshop content.
Fix: also check for folder.items before iterating.
Monitor GameMode D-Bus service (com.feralinteractive.GameMode) to automatically pause wallpapers when games are running via gamemoderun. Uses a Loader to only instantiate the monitor when the setting is enabled. Based on PR RainyPixel#8 by PolisanTheEasyNick (RainyPixel upstream).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Steam library path stored as URL instead of native path
Fix wallpaper scanning crash when optional directories do not exist