Open
Conversation
- Target Android Level 31 - Add exported requirement to AndroidManifest.xml - Upgraded Kotlin Version. - Upraded Gradle Version.
- Null Safety - Better Code Structure for Project - Upgrade dep to Null Safe Versions - Moved audio files to assets/audio - Moved image assets to assets/images - Mention License in README - Unify Ghost Widget to Single Widget to reduce code duplication. - Various Other Code Improvements.
Raj2503
reviewed
Jun 2, 2022
Owner
Raj2503
left a comment
Raj2503
left a comment
There was a problem hiding this comment.
Will the ghosts work/load properly if you combine all the ghost files into a single file?
Author
|
Yes, if we provide proper index, I tested the app and it's properly working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also closes #3