Skip to content

Migrate VGS from OpenShift private API to Kubernetes public API v1 - #2669

Draft
ELENAGER wants to merge 4 commits into
RamenDR:mainfrom
ELENAGER:public_vgs_api_only
Draft

Migrate VGS from OpenShift private API to Kubernetes public API v1#2669
ELENAGER wants to merge 4 commits into
RamenDR:mainfrom
ELENAGER:public_vgs_api_only

Conversation

@ELENAGER

@ELENAGER ELENAGER commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace the private groupsnapshot.storage.openshift.io VGS client with the public groupsnapshot.storage.k8s.io/v1 API (external-snapshotter client v8.6.0).
  • On upgrade, when both public and private VGS CRDs are present, RGS reconcile deletes Ramen-owned private VGS so they are not left as orphans.
  • Bump the drenv external_snapshotter addon to release-8.6 so test clusters match the public VGS CRDs/controller.

Test plan

  • make lint / unit tests for affected packages (util, cephfscg, controllers)
  • drenv with external_snapshotter addon: confirm VGS CRDs are groupsnapshot.storage.k8s.io/v1 and CephFS CG sync works
  • Upgrade-style check: with both public and private VGS CRDs installed and a leftover private VGS labeled created-by-ramen + rgs=<name>, confirm RGS reconcile deletes the private VGS
  • Confirm new VGS objects are created only with the public API

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c543aeb2-ad87-4d40-8eae-8edb9c321c24

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ELENAGER
ELENAGER force-pushed the public_vgs_api_only branch 2 times, most recently from f9ba197 to 2a02e9d Compare July 24, 2026 17:48
ELENAGER added 4 commits July 30, 2026 10:11
Replace the private red-hat-storage v1beta1 client with
kubernetes-csi external-snapshotter volumegroupsnapshot/v1 (v8.6.0).

Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
When both public and private VolumeGroupSnapshot CRDs are present,
delete Ramen-owned private VGS left from pre-upgrade clusters.

Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
Align public VolumeSnapshot/VolumeGroupSnapshot CRDs and controller
with client v8.6 used by Ramen.

Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
Signed-off-by: Elena Gershkovich <elenage@il.ibm.com>
@ELENAGER
ELENAGER force-pushed the public_vgs_api_only branch from 2a02e9d to 991089e Compare July 30, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant